Skip to content

Attempt to improve error meassage from rustfmt #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2017
Merged

Attempt to improve error meassage from rustfmt #2274

merged 2 commits into from
Dec 12, 2017

Conversation

topecongiro
Copy link
Contributor

This PR

  1. prevents printing usage when rustfmt failed due to IO errors. Also adds summary "Format Rust code".
  2. warns when there are unknown configuration options. Currently rustfmt does not emit any warning. Since we have removed and combined many config options, we should explicitly warn these changes to the user. This is not a hard error: rustfmt still formats files even when unknown config options is in rustfmt.toml.

@nrc nrc merged commit 30abfd6 into rust-lang:master Dec 12, 2017
@nrc
Copy link
Member

nrc commented Dec 12, 2017

Looks good, thank you!

@topecongiro topecongiro deleted the better-error-msg branch December 12, 2017 04:42
@gnzlbg gnzlbg mentioned this pull request May 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@topecongiro @nrc