Skip to content

Customisation of function decls #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 1, 2015
Merged

Customisation of function decls #238

merged 7 commits into from
Sep 1, 2015

Conversation

nrc
Copy link
Member

@nrc nrc commented Sep 1, 2015

I think this supports all the popular options from rust-lang/rfcs#1190. The defaults remain unchanged for now.

write_list(&items.collect::<Vec<_>>(), &fmt))
let preds_str = write_list(&items.collect::<Vec<_>>(), &fmt);

// 11 = " where ".len() + " {".len()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm counting 9 here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the opening brace is sometimes placed on a newline, right?

@marcusklaas
Copy link
Contributor

Noice! r+

nrc added a commit that referenced this pull request Sep 1, 2015
Customisation of function decls
@nrc nrc merged commit 6ca2756 into master Sep 1, 2015
@marcusklaas marcusklaas deleted the fn-decl branch September 27, 2015 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants