Remove faulty shortcut in rewrite_string_lit
#241
Merged
+11
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rustfmt would leave the literal unchanged when it did not exceed the column limit in its original position, not considering its position after formatting.
| yyyyyyyyyyyyyyyyyyyyy\ | ||
| yyyyyyyyyyyyyyyyyyyyy\ | ||
| yyyyyyyyyy"); | ||
|
|
There was a problem hiding this comment.
this doesn't look like an improvement, but I guess we need more infra to fix it.
There was a problem hiding this comment.
It's not an improvement on the test source, but it is an improvement on how rustfmt would previously format this. It would put everything on a single line.
nrc
added a commit
that referenced
this pull request
Sep 1, 2015
Remove faulty shortcut in `rewrite_string_lit`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rustfmt would leave the literal unchanged when it did not exceed the column limit in its original position, not considering its position after formatting.