Only reorder module declarations #2484
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. `mod foo;`
topecongiro
force-pushed
the
issue-2482
branch
from
bcaf761 to
b727557
Compare
nrc
reviewed
Feb 24, 2018
| @@ -233,7 +233,7 @@ impl ReorderableItemKind { | |||
| match item.node { | |||
| _ if contains_macro_use_attr(item) => ReorderableItemKind::Other, | |||
| ast::ItemKind::ExternCrate(..) => ReorderableItemKind::ExternCrate, | |||
| ast::ItemKind::Mod(..) => ReorderableItemKind::Mod, | |||
| ast::ItemKind::Mod(ref m) if m.inner.hi() != item.span.hi() => ReorderableItemKind::Mod, | |||
There was a problem hiding this comment.
Could you either factor out the test into a function, or add a comment please (it's a bit unclear what the guard is checking for).
There was a problem hiding this comment.
There is is_mod_decl in items.rs, so I am going to use that.
|
I am going to create a new PR with @nrc 's review applied. Thank you for your review! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2482.