Disallow combining a method call with prefix or suffix #2730
Conversation
| ); | ||
| // We should combine a small callee with an argument. | ||
| bar(vec![22] | ||
| .into_iter() |
There was a problem hiding this comment.
I think we should probably not combine in this case - I feel like the benefit of uniformity outweights the slight ugliness of the floating second line. Also, I think that the floating second line is worse if it beings with punctuation, rather than a name. E.g.,
// pretty bad
x
.foo
.bar
// not as bad
x(
foo.bar
)
There was a problem hiding this comment.
And the opening parens make this case look better too - similar to braces in a block (probably more important than the punctuation vs identifier distinction).
There was a problem hiding this comment.
Hmm, I though that we decided to combine a short function call and a single argument in #2178, but no?
There was a problem hiding this comment.
Hmm, we did, sorry (I'm not 100% sure I agree with my old self, but lets try it out).
|
The test failure is not related to this PR (poor clippy). |
Closes #2704.