Remove newline in empty impl #2741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrc
reviewed
May 27, 2018
tests/target/impls.rs
Outdated
| T: PartialEq, | ||
| { | ||
| } | ||
| T: PartialEq, {} |
There was a problem hiding this comment.
I think these changes are incorrect - we should only use the {} form (c.f., with a newline) if the whole impl fits on one line. Also, we should not have a trailing comma if there is a brace on the same line.
csmoe
commented
May 31, 2018
tests/target/impl.rs
Outdated
| @@ -28,7 +28,7 @@ impl<T> Foo for T | |||
| where | |||
| // comment2 | |||
| // blah | |||
| T: Clone, | |||
| T: Clone | |||
There was a problem hiding this comment.
trailing comma is trimmed since where clause contains comments. is it fine? @nrc
There was a problem hiding this comment.
I think we should not remove the comma - we should keep the comma if it is mulit-line and remove it if it is single line. Whether it is multiline because there are multiple clauses or because of comments shouldn't matter.
|
@csmoe failing tests due to overlong line |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2736