Skip to content

Fix breaking code block with # in doc comments #2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2018

Conversation

topecongiro
Copy link
Contributor

This PR is a followup of #2732, where I first added the support for formatting code block in doc comments with #. I have forgot to handle errors in the original PR:

  1. When we have failed to format the code block.
  2. When the code block does not have the trailing ```.
  3. When the # is indented.

This PR fixes #2732 and handle the above cases.

Closes #2759.

@topecongiro topecongiro changed the title Issue 2759 Fix breaking code block with # in doc comments Jun 5, 2018
@nrc nrc merged commit 95b4978 into rust-lang:master Jun 5, 2018
@nrc
Copy link
Member

nrc commented Jun 5, 2018

Thanks!

@topecongiro topecongiro deleted the issue-2759 branch June 5, 2018 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustfmt breaks doc api with wrap_comments=true
2 participants