Fix #2728. #2785
Merged
Fix #2728. #2785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrc
reviewed
Jun 18, 2018
src/lib.rs
Outdated
| @@ -718,10 +718,16 @@ fn format_code_block(code_snippet: &str, config: &Config) -> Option<String> { | |||
| let mut result = String::with_capacity(snippet.len()); | |||
| let mut is_first = true; | |||
|
|
|||
| // While formatting the code, ignore the config's newline style setting and always use "\n" | |||
| // instead of "\r\n" for the newline characters. | |||
There was a problem hiding this comment.
Why is it OK to do this? It seems like this would insert the wrong line ending if the user wants Windows line endings.
|
We are doing '\n' ==> "\r\n' conversion for the whole output files in another place, so it should be okay. All tests are still passing in Windows after this fix. |
|
Could you add that information to a comment please? r+ with that |
|
Added comment. The automatic test is failing but it looks it's not related to my PR. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do you mind if I clone() the whole config object?