Skip to content

Don't fail integration tests if the subject is not passing its own tests #2793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2018

Conversation

nrc
Copy link
Member

@nrc nrc commented Jun 18, 2018

As suggested in #2715 (comment)

@gnzlbg
Copy link
Contributor

gnzlbg commented Jun 18, 2018

@nrc which project was failing its own tests?

@nrc
Copy link
Member Author

nrc commented Jun 18, 2018

which project was failing its own tests?

stdsimd was before, but I don't think it is now. In practice any of them could be, I think.

@nrc nrc merged commit a1c5c46 into master Jun 18, 2018
@gnzlbg
Copy link
Contributor

gnzlbg commented Jun 19, 2018

Agreed, stdsimd is probably the most common one because as a component of std that requires compiler support, some changes to the compiler that break it take a bit to get propagated down to stdsimd.

@topecongiro topecongiro deleted the integr-test-fail branch July 21, 2019 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants