Skip to content

Fix normalisation of multiline doc attributes #3548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 20, 2019
Merged

Fix normalisation of multiline doc attributes #3548

merged 8 commits into from
May 20, 2019

Conversation

bash
Copy link

@bash bash commented May 11, 2019

I noticed that multiline #[doc = "..."] attributes are not formatted properly when I ran cargo expand on a proc_macro that emits doc attributes.

@bash bash changed the title Fix normalisation multiline doc attributes Fix normalisation of multiline doc attributes May 11, 2019
scampi
scampi suggested changes May 16, 2019
View reviewed changes
Copy link
Contributor

@scampi scampi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just small fixes

@bash bash mentioned this pull request May 17, 2019
Merged
topecongiro
topecongiro reviewed May 20, 2019
View reviewed changes
@topecongiro topecongiro merged commit 0482ac8 into rust-lang:master May 20, 2019
@topecongiro
Copy link
Contributor

Thanks!

@bash bash deleted the normalize-multiline-doc-attributes branch May 20, 2019 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scampi scampi scampi requested changes

@topecongiro topecongiro topecongiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bash @topecongiro @scampi