Skip to content

ignore empty string for license_template_path #3804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

calebcartwright
Copy link
Member

Resolves #3802

@topecongiro topecongiro merged commit 3bb2661 into rust-lang:master Sep 24, 2019
@topecongiro topecongiro added this to the 1.4.9 milestone Sep 24, 2019
@topecongiro
Copy link
Contributor

Thank you!

@calebcartwright calebcartwright deleted the empty-str-license-path branch September 24, 2019 00:46
Ok(re) => self.license_template = Some(re),
Err(msg) => eprintln!("Warning for license template file {:?}: {}",
lt_path, msg),
if lt_path.len() > 0 {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer !lt_path.is_empty()?

@bolinfest
Copy link

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore license_template_path if it is the empty string
3 participants