fix 'fails with conditional paths that include' #3955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topecongiro
reviewed
Dec 9, 2019
| @@ -31,7 +31,12 @@ macro_rules! span_with_attrs_lo_hi { | |||
| if attrs.is_empty() { | |||
| mk_sp($lo, $hi) | |||
| } else { | |||
| mk_sp(attrs[0].span.lo(), $hi) | |||
| // this path is already gone at latest rust-ap-* 627.0.0 | |||
| if attrs[0].item.path.to_string() == "warn_directory_ownership" { | |||
There was a problem hiding this comment.
Wow, does this mean that the rustc parser is adding an attribute internally to the AST node? That is...surprising 😅
There was a problem hiding this comment.
Yes. But it will be deleted at the current version rust-ap-*. Maybe because it's not good for AST.
topecongiro
approved these changes
Dec 9, 2019
|
I'm unable to reproduce the issue with the latest master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #3933