use let to bind value from a macro expression #3976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tesuji
force-pushed
the
let-macro-expr
branch
from
71a4217 to
af2163f
Compare
|
@calebcartwright I'm not sure if this needs to be backported. Maybe at the time it was recommended to use a let binding, but I don't know if that's the case anymore. Please correct me if I'm wrong. Also, It's an easy cherry-pick in case we do want to bring it into the 1.x branch, but I don't think it's something we necessarily need to do. |
|
Agreed. It's simple enough but unless clippy is barking about it or we're experiencing issues I think we can focus on the rest of the backport backlog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is recommended to do that as I could remember.