-
Notifications
You must be signed in to change notification settings - Fork 933
Declare & implement space_around_attr_eq
config.
#4040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare & implement space_around_attr_eq
config.
#4040
Conversation
This configuration setting controls the spacing around `=` when found inside of attributes. Eg: ```rust #[cfg(target_os="linux")] // vs #[cfg(target_os = "linux")] ``` The config setting `space_around_attr_eq` takes a bool value. Closes rust-lang#4039
4f6874b
to
d0e471f
Compare
Awesome! Let me know if you have any questions/issues with the tests (or anything else). I think there's only one existnig unit test that would need updating ( |
Ok, I think this PR is ready for an initial review. Tests are passing. Tried to match the other config snippets as closely as possible. |
Looks like the test failure is due to the issue @calebcartwright mentioned. I'll knock that out here soon. |
1479ff8
to
5ab22d9
Compare
5ab22d9
to
881305e
Compare
Finally ugh! CI kept hitting random failures in external systems. We're green now! |
@topecongiro any concerns/objections with this new config option? It seems reasonable to me and the changes seem good |
Sorry for the late review. Thanks! |
@topecongiro no problem. Thank you! |
This configuration setting controls the spacing around
=
when foundinside of attributes. Eg:
The config setting
space_around_attr_eq
takes a bool value.Closes #4039
todo