Skip to content

Triage issues #4242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 8, 2020
Merged

Triage issues #4242

merged 3 commits into from
Jun 8, 2020

Conversation

topecongiro
Copy link
Contributor

@topecongiro topecongiro commented Jun 7, 2020 •
edited
Loading

  • Add tests for already fixed issues
  • Assume the input is the root file if operating in recursive mode. Since the default operation mode has changed to non-recursive, we can assume that in recursive mode, the input file is most likely the root file (e.g., invoking rustfmt via cargo fmt). This heuristic is still not perfect, though we can expect fewer errors to surface than the current implementation, and give us some time until we come up with a better solution.

Close #1031.
Close #3762.
Close #3572.

calebcartwright
calebcartwright approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@topecongiro topecongiro merged commit 3035670 into rust-lang:master Jun 8, 2020
@topecongiro topecongiro deleted the triage-issues branch June 8, 2020 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
backport-triage
Projects
None yet
Milestone
No milestone
3 participants
@topecongiro @calebcartwright @karyon