Pick up comments between trait where clause and open block #4292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously rustfmt only picked up comments between a trait "signature" and its block when there was no `where` clause on the trait. Amending this to work for comments following a `where` clause and preceding the trait block is straightforward; we simply get rid of the branch and adjust the span to search for a comment in accordingly. Closes rust-lang#4289
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously rustfmt only picked up comments between a trait "signature"
and its block when there was no
whereclause on the trait. Amendingthis to work for comments following a
whereclause and preceding thetrait block is straightforward; we simply get rid of the branch and
adjust the span to search for a comment in accordingly.
Closes #4289