Add reformating for parentheses #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| debug!("rewrite_paren, subexpr_str: `{}`", subexpr_str); | ||
| let mut lines = subexpr_str.rsplit('\n'); | ||
| let last_line_len = lines.next().unwrap().len(); | ||
| let last_line_offset = if lines.next().is_none() {offset+1} else {0}; |
There was a problem hiding this comment.
better to spread this if expression over multiple lines
There was a problem hiding this comment.
and actually better to use a match expression than if ...is_none()
|
Thanks for the PR! From an idiomatic Rust point of view this looks great, the only non-idomatic thing I noticed was using I think I would format so there is never a dangling never If we ever need that one char to fit in the width, it would be better to either modify the sub-expression or to modify the enclosing expression. |
|
This last commit avoid dangling |
|
Thank you for the prompt review. |
|
Sweet, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm quite new to Rust, so I picked this for practice. Please tell me if it's not idiomatic for Rust.