Optionally put the opening paren on the previous line for args (Issue #31) #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, Existing code was making an assumption that one indentation level is 4 spaces so I also assumed that but there's a config |
|
@tdudziak Yes, please use |
nrc
added a commit
that referenced
this pull request
May 28, 2015
Optionally put the opening paren on the previous line for args (Issue #31)
|
Thanks for the PR, sorry it took a while to merge, I wanted to play with it locally to make sure it was doing the right thing - which it was :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new config option
fn_args_paren_newlineto control this (defaults to previous behavior). Only tested locally --- I can add some testcases but I don't think there's support for per-test Config options.