Implement reformat of tuple litterals #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .enumerate() | ||
| .map(|(i, item)| self.rewrite_expr( | ||
| item, | ||
| // for last line, -2 is for indent + ")", for other lines, -1 is for comma |
There was a problem hiding this comment.
I think the 'other lines' should also be -2 because they are also offset by the opening (
|
Do you handle tuples with len == 1 properly? These should be formatted as Otherwise, this looks good! |
|
I simply added a special case for tuples of length 1, the general algo is not adapted because |
nrc
added a commit
that referenced
this pull request
May 31, 2015
Implement reformat of tuple litterals
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.