fixup reductions

Author: gnzlbg

coresimd/ppsv/api/arithmetic_reductions.rs

@@ -17,7 +17,7 @@ macro_rules! impl_arithmetic_reductions {
             pub fn product(self) -> $elem_ty {
                 use ::coresimd::simd_llvm::simd_reduce_mul_ordered;
                 unsafe {
-                    simd_reduce_add_ordered(self, 1 as $elem_ty)
+                    simd_reduce_mul_ordered(self, 1 as $elem_ty)
                 }
             }
         }

coresimd/ppsv/api/bitwise_reductions.rs

@@ -33,30 +33,33 @@ macro_rules! impl_bitwise_reductions {
 }
 
 macro_rules! impl_bool_bitwise_reductions {
-    ($id:ident, $elem_ty:ident) => {
+    ($id:ident, $elem_ty:ident, $internal_ty:ident) => {
         impl $id {
             /// Lane-wise bitwise `and` of the vector elements.
             #[inline]
             pub fn and(self) -> $elem_ty {
                 use ::coresimd::simd_llvm::simd_reduce_and;
                 unsafe {
-                    simd_reduce_and(self) != 0
+                    let r: $internal_ty = simd_reduce_and(self);
+                    r != 0
                 }
             }
             /// Lane-wise bitwise `or` of the vector elements.
             #[inline]
             pub fn or(self) -> $elem_ty {
                 use ::coresimd::simd_llvm::simd_reduce_or;
                 unsafe {
-                    simd_reduce_or(self) != 0
+                    let r: $internal_ty = simd_reduce_or(self);
+                    r != 0
                 }
             }
             /// Lane-wise bitwise `xor` of the vector elements.
             #[inline]
             pub fn xor(self) -> $elem_ty {
                 use ::coresimd::simd_llvm::simd_reduce_xor;
                 unsafe {
-                    simd_reduce_xor(self) != 0
+                    let r: $internal_ty = simd_reduce_xor(self);
+                    r != 0
                 }
             }
         }

coresimd/ppsv/api/mod.rs

@@ -244,7 +244,7 @@ macro_rules! simd_b_ty {
             [define_ty, $id, $($elem_tys),+ | $(#[$doc])*],
             [impl_bool_minimal, $id, $elem_ty, $elem_count, $($elem_name),*],
             [impl_bitwise_ops, $id, true],
-            [impl_bool_bitwise_reductions, $id, bool],
+            [impl_bool_bitwise_reductions, $id, bool, $elem_ty],
             [impl_bool_reductions, $id],
             [impl_bool_cmp, $id, $id],
             [impl_eq, $id],