Skip to content

Fix integer overflow in vadd aarch64 test cases #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

SparrowLii
Copy link
Member

When I tested on my aarch64, I found that some of the vadd test cases would panic due to the overflow of x+y. Use wrapping_add (discard the overflow part) to avoid them. This will be consistent with the behavior of the instruction itself.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@SparrowLii SparrowLii force-pushed the vaddtest branch 2 times, most recently from b281038 to d0099a9 Compare February 26, 2021 02:16
@Amanieu Amanieu merged commit fc71718 into rust-lang:master Feb 26, 2021
@Amanieu
Copy link
Member

Amanieu commented Feb 26, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants