some Avx512f to const generics #1064
Conversation
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
|
Avx512f only has 2 (extract_i32x4,i64x4) left which are not converted to const generics. |
| match imm8 & 0x3 { | ||
| #[rustc_legacy_const_generics(1)] | ||
| pub unsafe fn _mm512_extractf32x4_ps<const IMM8: i32>(a: __m512) -> __m128 { | ||
| static_assert_imm8!(IMM8); |
There was a problem hiding this comment.
This should be using static_assert_imm2. Same with the other extract/insert below. This matches the behavior in Clang.
There was a problem hiding this comment.
(it's also what's documented in the intel intrinsics guide)
I'll take care of that as soon as this PR lands |
crates/core_arch/src/x86/ssse3.rs
Outdated
| } else { | ||
| shift + i | ||
| } | ||
| } |
There was a problem hiding this comment.
This function isn't actually used anywhere.
There was a problem hiding this comment.
Sorry, I was thinking how to do for mm256_alignr_epi8. I remove it now
256_mask_slli_epi32,epi64; mm_mask_slli_epi32,epi64
256_mask_slli_epi32,epi64; mm_mask_slli_epi32,epi64
Inserti32x4,f32x4,i64x4,f64x4
extract_f32x4_ps,f64x4_pd
mm256_alignr_epi8
mm512_alignr_epi8
bslli_epi128; bsrli_epi128
mm512_shufflehi_epi16, mm512_shufflelo_epi16