std_detect: Support run-time detection of FEAT_LSE2 on aarch64 BSD #1379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rustbot has picked a reviewer for you, use r? to override) |
If FEAT_LSE2 is implemented, AT field of ID_AA64MMFR2_EL1 is 0b0001. https://developer.arm.com/documentation/ddi0601/2022-12/AArch64-Registers/ID-AA64MMFR2-EL1--AArch64-Memory-Model-Feature-Register-2?lang=en#fieldset_0-35_32 Also, if FEAT_LSE is implemented, Atomic field of ID_AA64ISAR0_EL1 is >= 0b0010, not >= 0b0001. (0b0001 is reserved) https://developer.arm.com/documentation/ddi0601/2022-12/AArch64-Registers/ID-AA64ISAR0-EL1--AArch64-Instruction-Set-Attribute-Register-0?lang=en#fieldset_0-23_20
taiki-e
force-pushed
the
std-detect-aarch64-bsd-lse2
branch
from
8ca3a59 to
d090379
Compare
lu-zero
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If FEAT_LSE2 is implemented, AT field of ID_AA64MMFR2_EL1 is 0b0001. https://developer.arm.com/documentation/ddi0601/2022-12/AArch64-Registers/ID-AA64MMFR2-EL1--AArch64-Memory-Model-Feature-Register-2?lang=en#fieldset_0-35_32
Also, if FEAT_LSE is implemented, Atomic field of ID_AA64ISAR0_EL1 is >= 0b0010, not >= 0b0001. (0b0001 is reserved) This patch fixes it too.
https://developer.arm.com/documentation/ddi0601/2022-12/AArch64-Registers/ID-AA64ISAR0-EL1--AArch64-Instruction-Set-Attribute-Register-0?lang=en#fieldset_0-23_20