Skip to content

Shuffle around stdsimd::arch::detect bits #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2018

Conversation

alexcrichton
Copy link
Member

Compile more code on more platforms, tweak imports, try to catch mistakes
sooner.

@alexcrichton
Copy link
Member Author

This is fixing this error which wasn't caught during x86/x86_64 builds. I'm hoping to build a maximal amount of code on all platforms to check as much as we can statically and then most of it just ends up being dead code that's eliminated.

@gnzlbg
Copy link
Contributor

gnzlbg commented Apr 14, 2018

It would be nice to triple-check that the cache is indeed eliminated on platforms that don't need it.

@gnzlbg
Copy link
Contributor

gnzlbg commented Apr 14, 2018

Also in which platforms is this code failing, and why isn't it failing in stdsimd's CI ?

@alexcrichton
Copy link
Member Author

Oh yeah this is for sure all jettisoned from libstd, and it's an issue with integrating into libstd rather than stdsimd itself. In libstd there's no top-level _std item, but rather more tweaks need to happen for reexported items in the stdsimd crate's ci to integrate well into libstd

@gnzlbg
Copy link
Contributor

gnzlbg commented Apr 14, 2018

but rather more tweaks need to happen for reexported items in the stdsimd crate's ci to integrate well into libstd

Ah crap, maybe I screwed it up last time I touched it. Could you add a comment to the top-level crates explaining a bit how things must be done to not break anything in libstd ?

Compile more code on more platforms, tweak imports, try to catch mistakes
sooner.
@alexcrichton
Copy link
Member Author

Oh no worries, I've renamed the import of std to __do_not_use_this_import to discourage further use :)

@alexcrichton alexcrichton merged commit dc35c8c into rust-lang:master Apr 15, 2018
@alexcrichton alexcrichton deleted the another-fix branch April 15, 2018 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants