Avx512bw #953
Merged
Avx512bw #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust_highfive has picked a reviewer for you, use r? to override) |
Amanieu
reviewed
Nov 22, 2020
| @@ -63,7 +63,6 @@ pub struct poly8x16x4_t( | |||
|
|
|||
| #[allow(improper_ctypes)] | |||
| extern "C" { | |||
| // absolute value | |||
There was a problem hiding this comment.
Couple days ago, it seems there is a modified to affect to pass the style check. Now, it should be fixed.
There was a problem hiding this comment.
Let me put back and see if it will pass the style test
crates/core_arch/src/arm/neon/mod.rs
Outdated
| @@ -115,7 +115,6 @@ pub struct poly8x8x4_t(pub poly8x8_t, pub poly8x8_t, pub poly8x8_t, pub poly8x8_ | |||
|
|
|||
| #[allow(improper_ctypes)] | |||
| extern "C" { | |||
| // absolute value (64-bit) | |||
crates/core_arch/src/simd_llvm.rs
Outdated
| @@ -1,7 +1,6 @@ | |||
| //! LLVM's SIMD platform intrinsics | |||
|
|
|||
| extern "platform-intrinsic" { | |||
| //pub fn simd_select_bitmask | |||
crates/core_arch/src/x86/sse42.rs
Outdated
| @@ -653,7 +653,6 @@ pub unsafe fn _mm_cmpgt_epi64(a: __m128i, b: __m128i) -> __m128i { | |||
|
|
|||
| #[allow(improper_ctypes)] | |||
| extern "C" { | |||
| // SSE 4.2 string and text comparison ops | |||
|
Style check seems to pass, can you fix the other removed lines as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix set_epi8, set_epi16 in avx512f
cmplt, cmpgt, cmple, cmpge, cmpeq, cmpneq, cmp_mask: epu8,epu16,epi8,epi16
loadu: epi8,epi16; storeu: epi8,epi16
abs: epi8,epi16
add: epi8,epi16; adds: epu8,epu16,epi8,epi16
sub: epi8,epi16, subs: epu8,epu16,epi8,epi16
mulhi: epu16,epi16; mulhrs: epi16; mullo: epi16
max: epu8,epu16,epi8,epi16; min: epu8,epu16,epi8,epi16
madd: epi16; maddubs: epi16
sll: epi16; slli: epi16, sllv: epi16; srl: epi16; srli: epi16, srlv: epi16
packs: epi32,epi16; packus: epi32,epi16
avg: epu8,epu16
permutex2var: epi16; permutexvar: epi16
blend: epi16,epi8; broadcastw: epi16; broadcastb: epi8
unpackhi: epi16,epi8; unpacklo: epi16,epi8
mov: epi16,epi8; mask_set1: epi16,epi8
shufflelo: epi16; shufflehi: epi16