WIP Theme support #1089
Closed
WIP Theme support #1089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'm happy to accept this. There is already a dark-mode for newsletter theme. Probably best to use same colours here? |
|
Link to dark-mode PR: #1035. |
|
Ah, sorry for not replying: I don’t really like the complete white-on-black there. It works for small OLED screens, but even then, I’m not a fan of that white headerbar. Do we have any other precedent? Any dark theme done by a designer instead of me or @dvogt23? |
|
Going to go ahead and close this due to age of the issue. Feel free to open this again if you wish to update it :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs work to support links and code, but first I wanted to know if the approach is OK:
Since this is a dynamic property, I use CSS variables to avoid having to duplicate all rules using a variable inside of a @media block. I renamed the dynamic colors to a more semantic gradient of 5 greys and a brand color.
Honestly we can probably leave the brand color static, or we reuse it for links. Also the primary button doesn’t seem to use the brand color at all anyway?
I also added some code to make it work with Python 3 (which lacks cssmin) and newer Pelican versions.