Skip to content

TWIR 344 #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2020
Merged

TWIR 344 #1321

merged 2 commits into from
Jun 23, 2020

Conversation

cdmistman
Copy link
Contributor

No description provided.

Copy link
Contributor

@nellshamrell nellshamrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! Thank you so much for this work!

Just one minor fix and this is good to go!

@@ -36,6 +36,24 @@ Check out [this week's *This Week in Rust Podcast*]()
* [SIMD library plans](https://vorner.github.io/2020/05/08/simd-library-plans.html)
* [Tips for Faster Rust Compile Times](https://endler.dev/2020/rust-compile-times/)
* [Rust Analyzer Changelog #30](https://rust-analyzer.github.io/thisweek/2020/06/22/changelog-30.html)
* [Building A Blockchain in Rust & Substrate: [A Step-by-Step Guide for Developers]](https://hackernoon.com/building-a-blockchain-in-rust-and-substrate-a-step-by-step-guide-for-developers-kc223ybp)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you've got an extra bracket on this line (right after the word "Developers")

* [How to use C++ polymorphism in Rust](https://medium.com/swlh/how-to-use-c-polymorphism-in-rust-76e1d1a88ed1)
* [Implementing a Type-safe printf in Rust](http://willcrichton.net/notes/type-safe-printf/)
* [Introduction to Rust for Node Developers](https://dev.to/tindleaj/introduction-to-rust-for-node-developers-3j05)
* [The programming language that wants to rescue the world from dangerous code](https://www.protocol.com/rust-programming-safety-security)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hee! Thanks for including the one I'm quoted in :D

@nellshamrell
Copy link
Contributor

Realized I could make the requested change myself, all is good!

@nellshamrell nellshamrell merged commit 8fa036a into rust-lang:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants