Skip to content

TWiR #349 #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2020
Merged

TWiR #349 #1397

merged 3 commits into from
Jul 28, 2020

Conversation

cdmistman
Copy link
Contributor

I did a few experimental things...

  1. I added subsections in the "Updates from Rust Community" section
  2. To make that section cleaner (and because "News and Blog Posts" was the only 2nd-level section in there), I got rid of the "News and Blog Posts" subsection and made all subsections direct subsections of the section (sorry for word vomit, might be easier to see in the file)
  3. Changed non-english language links to use 2-letter ISO code instead of the English name for the language.

If anything should be changed let me know!

@nellshamrell
Copy link
Contributor

Hi there! Thank you so much! I love #1 and #3 - but I'm wondering if we might keep the News & Blog post heading and make the labels subsections under News & Blog Posts. I tend to prefer this to make it more distinct from the following sections (CFPs, RFCs, etc.)

@cdmistman
Copy link
Contributor Author

What if we change the subsections for "Updates from Rust Community" to be 3rd-level? This would bring the style closer to the current "Upcoming Events" section. I'm ok with keeping the "News & Blog Posts", I'm just wary of the redundancy since that's the only subsection of "Updates from Rust Community"

@nellshamrell
Copy link
Contributor

Ah....I see what you mean. That - changing the subsections of "Updates from the Rust Community" to be 3rd level - sounds good to me!

Copy link
Contributor

@nellshamrell nellshamrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@nellshamrell nellshamrell merged commit c9043f0 into rust-lang:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants