add header links #3863
Merged
add header links #3863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndd7xv
force-pushed
the
anchor-headers
branch
3 times, most recently
from
d7d9795 to
846bdf2
Compare
|
Also note that I disabled in the newsletter because they were relative linking; the link in the README is dead (http://zurb.com/ink/inliner.php) but I tried testing the inline emails by creating an account with app.postdrop.io |
|
Ty so much! I will get this reviewed either before or during the weekend! |
|
Taking a look now! |
|
Hi there! Ty so much for this! Is there any way to make the text of the header the anchor, rather than adding the anchor symbol to the end of the header? |
ndd7xv
force-pushed
the
anchor-headers
branch
from
846bdf2 to
01d2ee9
Compare
|
Thanks for the review! Made the text the anchor and overrode its color to remain the same as before instead of having it turn blue like the other hyperlinks. Let me know if there's anything else! |
|
This looks FANTASTIC! Ty so much @ndd7xv! Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3669 if merged
Hi again! Same author of the dark mode draft PR; basically just searched up how to add anchors in pelican and used the first link with some documentation to get the following result:
Again, no experience with UI and my design choices are subjective, but I chose to have a permalink with this specific css to prevent it from being to obtrusive and taking the same colors as other links, while also making it easy to find.
Let me know if there's anything I can/should change!