Dark theme accessibility #4069
Merged
Dark theme accessibility #4069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @robbystk ! This is a great improvement in accessibility, and I particularly like the use of the contrastchecker website. Merging now (Left showing old coloring, right showing new) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
For #4031
In dark mode,
<code>elements are red-on-black which is difficult to readWhat Changed
--code-colorvariable with existing colorPrevious contrast ratio: 2.59:1
New contrast ratio: 5.48:1
Testing
pelican --delete-output-directory content<code>elements in one of the posts. The 'Updates from the Rust Project' section has several