Skip to content

Add status quo story about Alan trying to debug an app hang #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 5, 2021
Merged

Add status quo story about Alan trying to debug an app hang #106

merged 4 commits into from
Apr 5, 2021

Conversation

wesleywiser
Copy link
Member

I believe this captures the essence of #76 and may also touch on #75 a bit as some of that info could have been useful to Alan when trying to debug what's going on.

wesleywiser
wesleywiser commented Mar 29, 2021
View reviewed changes
nikomatsakis
nikomatsakis approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seemed very good to me. I don't have any suggestions for improvement but I'll wait until somebody else gives it a read to merge.

ibraheemdev
ibraheemdev suggested changes Mar 30, 2021
View reviewed changes
Copy link
Member

@ibraheemdev ibraheemdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nits. This looks very good 👍 I do think it would be worth expanding on the section where Alan tries info threads.

@pnkfelix
Copy link
Member

Looks great to me. Great jobs on all those nits you caught, @ibraheemdev !

rylev
rylev approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! I agree it would be nice to have a bit more detail on Alan's thought process when figuring out how to get visibility into running tasks. Once that's added, I think we can merge.

@nikomatsakis
Copy link
Contributor

@wesleywiser do you have some thoughts about what to add, per @rylev's suggestion?

@wesleywiser
Copy link
Member Author

@nikomatsakis Yeah, I think I have a few ideas. Working on it now 🛠️

@wesleywiser
Copy link
Member Author

Expanded on that section a bit. I think this is ready to go!

Stupremee
Stupremee reviewed Apr 4, 2021
View reviewed changes
@wesleywiser
Copy link
Member Author

Thanks @Stupremee! I've updated the formatting to match.

@nikomatsakis nikomatsakis merged commit c60549b into rust-lang:master Apr 5, 2021
@nikomatsakis
Copy link
Contributor

This looks great. Thanks @wesleywiser

@wesleywiser wesleywiser deleted the alan-tries-to-debug-hang branch April 5, 2021 15:19
@nikomatsakis nikomatsakis added the status-quo-story-ideas "Status quo" user story ideas label Apr 6, 2021
@rylev rylev mentioned this pull request Apr 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stupremee Stupremee Stupremee left review comments

@ibraheemdev ibraheemdev ibraheemdev requested changes

@nikomatsakis nikomatsakis nikomatsakis approved these changes

@rylev rylev rylev approved these changes

Assignees
No one assigned
Labels
status-quo-story-ideas "Status quo" user story ideas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wesleywiser @pnkfelix @nikomatsakis @rylev @ibraheemdev @Stupremee