prep for shiny future #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frederik-Baetens
force-pushed
the
prep_shiny_future
branch
from
f6f2ceb to
230596b
Compare
Frederik-Baetens
force-pushed
the
prep_shiny_future
branch
from
230596b to
66a515c
Compare
nikomatsakis
requested changes
Apr 3, 2021
There was a problem hiding this comment.
Thanks @Frederik-Baetens! This looks great. I am doing a quick look over the page to look for other things that should be updated:
- This page says "Folks open "status quo" and (starting 2021-04-02) "shiny future" story PRs", we can probably remove the parenthetical.
That looks like it for now.
|
Thanks @Frederik-Baetens! Note to all, I'd like to hold off on merging this until we are ready. Regarding the names of issue templates, I have no idea. I think I created it with the web gui and it did what it did. =) |
Co-authored-by: Niko Matsakis <[email protected]>
Frederik-Baetens
force-pushed
the
prep_shiny_future
branch
2 times, most recently
from
8d64985 to
6d18dd2
Compare
Frederik-Baetens
force-pushed
the
prep_shiny_future
branch
from
6d18dd2 to
798e1d5
Compare
nikomatsakis
approved these changes
Apr 4, 2021
nikomatsakis
approved these changes
Apr 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do the issue templates need to start with a - ? That makes working with them a bit annoying.
resolves #116