-
Notifications
You must be signed in to change notification settings - Fork 89
shiny future: Barbara makes a wish #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nikomatsakis
merged 11 commits into
rust-lang:master
from
pnkfelix:barbara-makes-a-wish
Apr 13, 2021
Merged
shiny future: Barbara makes a wish #138
nikomatsakis
merged 11 commits into
rust-lang:master
from
pnkfelix:barbara-makes-a-wish
Apr 13, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stupremee
reviewed
Apr 10, 2021
ibraheemdev
suggested changes
Apr 10, 2021
Lots of typos fixed, thanks everyone! Co-authored-by: Ibraheem Ahmed <[email protected]>
nikomatsakis
approved these changes
Apr 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave this a quick read, it's great! Will look more closely later on.
rylev
reviewed
Apr 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great start to the shiny futures!
… whether all async executors are compatible. (Most likely, they are not.)
…de something up when I wrote this.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a retelling of Barbara wants Async Insights.
I suspect the tool it outlines would have impact on other stories (which I did not take the time yet to evaluate; I hope that will get added before this is merged).
Also, the tool presented here would address other points raised in the FAQ of that story. But I am also trying to provide a model of how I would like shiny future stories to be written, and so I did not attempt to address all those points in one narrative. Instead, I tried to provide one clear story.