Skip to content

Use different purple #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Use different purple #1020

merged 1 commit into from
Mar 2, 2020

Conversation

XAMPPRocky
Copy link
Member

This updates the colour scheme based on talking with @pietroalbini to use a purple that is more deep blue.

New / Production

Screenshot 2020-03-01 at 14 09 58

New / Master

Screenshot 2020-03-01 at 14 10 18

@pietroalbini
Copy link
Member

pietroalbini commented Mar 1, 2020

I'd slightly prefer a saturation of 30% / 35%, but this looks way better to me! @Manishearth what do you think?

@XAMPPRocky
Copy link
Member Author

Here's a screenshot of 30%, personally I don't like it as it looks too gray compared to the new purple.

New / 30% Saturation

Screenshot 2020-03-01 at 20 49 50

@pietroalbini
Copy link
Member

The color introduced in the PR is starting to grow on me! Let's wait for @Manishearth's approval and then we can merge this.

By the way, I chatted with Erin and it turns out there was a miscommunication, the color with 30% saturation I was proposing is #312a4f.

@Manishearth
Copy link
Member

Yeah, this looks way better to me as well (and my understanding is that in the poll about colors people liked the new green but not the new-now-old purple)

@Manishearth Manishearth merged commit 3272ec5 into master Mar 2, 2020
@Manishearth Manishearth deleted the try branch March 2, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants