Display team alumni in the governance page #1025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. Could you also include a screenshot of how this looks on mobile? |
|
On mobile:
Also fixed the tests. |
|
Hmm, on mobile I think it might look better if it was two people per row. |
|
That could break with long names (such as Aidan Hobson Sayers). |
Manishearth
approved these changes
Mar 6, 2020
XAMPPRocky
reviewed
Mar 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support in the website for "team alumni", in the effort to move away from the alumni page. This PR displays alumni under each team instead, like this screenshot with dummy data:
At the moment no actual change will be shown, as nobody is marked as alumni in the team repo yet.
r? @XAMPPRocky