Fix learn URL #1041
Closed
Fix learn URL #1041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
reviewed
Mar 19, 2020
| @@ -4,7 +4,7 @@ | |||
| <div class="flex flex-column mw8 w-100 measure-wide-l pv2 pv5-m pv2-ns ph4-m ph4-l" id="get-help"> | |||
| <h4>{{fluent "footer-get-help"}}</h4> | |||
| <ul> | |||
| <li><a href="{{baseurl}}/learn">{{fluent "footer-doc"}}</a></li> | |||
| <li><a href="https://www.rust-lang.org/{{lang}}/learn">{{fluent "footer-doc"}}</a></li> | |||
There was a problem hiding this comment.
this should still use the baseurl
There was a problem hiding this comment.
Wait, no, the baseurl already includes the lang
|
#1040 is working, I don't see what the issue is. It's deployed at https://www-staging.rust-lang.org |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description
Fix #1039
Fix #1040
#1040 is not correctly work
If I visit
https://www.rust-lang.org/ja/tools, This link will redirect tohttps://www.rust-lang.org/ja/tools/learnRemarks
I have not test this PR.
I will test as soon.