upgrade function calls to reqwest in issue #1059 #1084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumping reqwest 0.9.24 to 0.10.4 requires use of calls that block
|
Formatting fail. |
|
You can just update this PR, you don't have to close it. |
|
I'm not sure why the formatting check is not passing. This branch doesn't have the offending lines formatted the way the builder is indicating. Also, should I do additional tests besides running the site locally? |
XAMPPRocky
reviewed
Apr 23, 2020
Formatting updated Co-Authored-By: XAMPPRocky <[email protected]>
|
Thank you for your PR, and congrats on your first ever contribution! 🎉🥳 |
|
Thanks for the help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bumping reqwest 0.9.24 to 0.10.4 requires use of calls that block. closes #1059