Skip to content

add link to forge #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2020
Merged

add link to forge #1102

merged 1 commit into from
May 8, 2020

Conversation

anton-iskryzhytskyi
Copy link
Contributor

@anton-iskryzhytskyi anton-iskryzhytskyi mentioned this pull request May 7, 2020
Closed
XAMPPRocky
XAMPPRocky suggested changes May 7, 2020
View reviewed changes
Copy link
Member

@XAMPPRocky XAMPPRocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! Would you be able to remove the non-english translations? As localisation needs to go through pontoon for review. Once the feedback has been addressed I would be happy to merge it in.

locales/en-US/common.ftl Outdated
@@ -42,6 +42,7 @@ nav-logo-alt = Rust Logo
footer-doc = Documentation
footer-ask = Ask a Question on the Users Forum
footer-status = Check Website Status
footer-sup-doc = Supplementary Documentation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is a bit more descriptive, as a lot of people know it as forge.

Suggested change
footer-sup-doc = Supplementary Documentation
footer-sup-doc = Rust Forge (Contributor Documentation)

@anton-iskryzhytskyi
Copy link
Contributor Author

Thank you for your PR! Would you be able to remove the non-english translations? As localisation needs to go through pontoon for review. Once the feedback has been addressed I would be happy to merge it in.

Should I create new PRs for non-english translations? Russian is my native language, so I can translate it correctly in any case.

Working on correcting comments

Thank you for the fast response!

@XAMPPRocky
Copy link
Member

XAMPPRocky commented May 8, 2020 •
edited
Loading

If you'd like to help with the translation efforts you need to do through https://pontoon.rust-lang.org it's our translation software that we use to manage and coordinate the localisation teams, any changes made there are automatically synced daily to this repository. You can read more about how translating the website works in the document linked below.

https://github.com/rust-lang/www.rust-lang.org/blob/master/TRANSLATIONS.md

@XAMPPRocky
Copy link
Member

Thank you again for your PR, and congrats on your first contribution! 🎉

@XAMPPRocky XAMPPRocky merged commit bf8304c into rust-lang:master May 8, 2020
@anton-iskryzhytskyi anton-iskryzhytskyi deleted the feature/forge-link branch May 8, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XAMPPRocky XAMPPRocky Awaiting requested review from XAMPPRocky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anton-iskryzhytskyi @XAMPPRocky