Skip to content

fix mistake with the cargo add command #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

PhantomMorrigan
Copy link
Contributor

The cargo add command in the example is installs an older version of ferris-says, that causes the code not to compile if the cargo add command is used to install the dependency.

Closes #1860.

the cargo add command in the example is installs an older version of ferris-says, that causes the code not to compile.
@PhantomMorrigan PhantomMorrigan requested a review from a team as a code owner September 2, 2023 19:10
@senekor
Copy link
Contributor

senekor commented Sep 2, 2023

Good catch. I would tend to replace it with cargo add [email protected] though. Otherwise stuff will break again without a mistake on our side if ferris-says releases a breaking version 0.4, which cargo add would automatically choose.

@Manishearth
Copy link
Member

ah, this was missed during the upgrade, thanks!

@Manishearth
Copy link
Member

AIUI ferris-says isn't planning on doing further updates so I'm comfortable with this

@Manishearth Manishearth merged commit de63e86 into rust-lang:master Sep 2, 2023
@PhantomMorrigan
Copy link
Contributor Author

A friend of mine had encountered this when trying out rust, so i just went and fixed it. Thanks for the quick response

@willbchang
Copy link

The command is still not updated on the page: https://www.rust-lang.org/learn/get-started

image

@senekor
Copy link
Contributor

senekor commented Sep 12, 2023

@willbchang the change isn't deployed yet. Deploys of the site are manual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mistake in getting started example project
4 participants