Skip to content

Reduce vertical padding on homepage #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 29, 2018
Merged

Reduce vertical padding on homepage #449

merged 5 commits into from
Nov 29, 2018

Conversation

nicoburns
Copy link
Contributor

Fixes #446

@ashleygwilliams
Copy link
Member

@nicoburns thanks for this! could you include a few screencaps please? ideally in the 3 forms: mobile, tablet, desktop. thank you!

@ashleygwilliams ashleygwilliams added this to the edition-release milestone Nov 29, 2018
@nicoburns
Copy link
Contributor Author

Screenshots (emulated with chrome dev tools).

Iphone 6:

Ipad:

Laptop 1400x1018:

ashleygwilliams
ashleygwilliams suggested changes Nov 29, 2018
View reviewed changes
Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we bump the space just a little bit.. maybe 10px more? otherwise i think this looks good to go. just a little cramped on desktop and ipad (mobile looks awesome!)

@nicoburns
Copy link
Contributor Author

nicoburns commented Nov 29, 2018 •
edited
Loading

Padding increased by 2rem (tachyons levels 4) on non-mobile sizes. Agreed that it looks better with a little extra space.

localhost_7878_ copy
localhost_7878_ ipad copy

ashleygwilliams
ashleygwilliams approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much! this is really great :

@ashleygwilliams ashleygwilliams merged commit d9ce215 into rust-lang:master Nov 29, 2018
@ashleygwilliams ashleygwilliams mentioned this pull request Nov 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleygwilliams ashleygwilliams ashleygwilliams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
edition-release
Development

Successfully merging this pull request may close these issues.
2 participants
@nicoburns @ashleygwilliams