Skip to content

Add blurb before domains #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 4, 2018
Merged

Add blurb before domains #501

merged 3 commits into from
Dec 4, 2018

Conversation

mark-i-m
Copy link
Member

@mark-i-m mark-i-m commented Nov 30, 2018 •
edited
Loading

I also added a blurb before the WG spotlights. The crates.io image comes from the rust-lang/crates.io repo (public/cargo.png). Also, I'm not familiar with the stylesheets being used, so please let me know if I am using the wrong classes or something.

EDIT: as per #501 (review) , I am just adding a the blurb for now...

r? @aturon

@mark-i-m mark-i-m mentioned this pull request Nov 30, 2018
Closed
@mark-i-m
Copy link
Member Author

Oops... forgot to include a screenshot

screenshot_2018-11-30 rust - index

ashleygwilliams
ashleygwilliams previously requested changes Nov 30, 2018
View reviewed changes
Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the sentence looks pretty great but i dont think the crates.io callout works. for the sake of small PRs perhaps we can make this PR just the sentence, and figure out crates.io in another issue?

ashleygwilliams
ashleygwilliams reviewed Nov 30, 2018
View reviewed changes
templates/panels/domains.hbs

<div class="flex-none flex-l flex-row">
<p class="flex-grow-1">
In 2018, the Rust community decided to improve programming experience
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might want to link to the 2018 roadmap here!

@ashleygwilliams ashleygwilliams added this to the edition-release milestone Nov 30, 2018
@mark-i-m
Copy link
Member Author

but i dont think the crates.io callout works. for the sake of small PRs perhaps we can make this PR just the sentence, and figure out crates.io in another issue?

sure, perhaps we can continue discussion on #458?

I removed all but the sentence.

@mark-i-m mark-i-m changed the title Highlight crates.io Add blurb before domains Nov 30, 2018
ashleygwilliams
ashleygwilliams reviewed Nov 30, 2018
View reviewed changes
Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me now- i imagine that @aturon may have wording changes. my only request is to remove the crates.io image for now! thanks <3

@mark-i-m
Copy link
Member Author

mark-i-m commented Dec 1, 2018

Ooops. I forgot the image. Removed now.

@ashleygwilliams
Copy link
Member

@aturon can you review the sentence? i think we may want some tweaks but i'm going to leave that in your court :)

@aturon
Copy link
Member

aturon commented Dec 2, 2018 via email

@chriskrycho chriskrycho dismissed ashleygwilliams’s stale review December 4, 2018 03:50

Per @aturon, this is a good-enough start (and people are traveling!). Merging.

@chriskrycho chriskrycho merged commit a758cea into rust-lang:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleygwilliams ashleygwilliams ashleygwilliams left review comments

@aturon aturon Awaiting requested review from aturon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
edition-release
Development

Successfully merging this pull request may close these issues.
4 participants
@mark-i-m @ashleygwilliams @aturon @chriskrycho