Don't say "other classes of bugs" without antecedent for "other" #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes the file `templates/panels/language-values.hbs`, where it promotes Rust as enabling the reader "to eliminate many other classes of bugs at compile-time", to say "to eliminate many classes of bugs at compile-time" instead, without the word "other", because no classes of bugs per se previously are mentioned, leaving "other" lacking an antecedent. Per `CONTRIBUTING.md`, I have filed [an issue ticket][1] first to suggest this change; the change was approved, and this patch requested, by @aturon. GitHub: Resolve rust-lang#476 [1]: <rust-lang#476>
chriskrycho
approved these changes
Dec 1, 2018
|
Thank you! Excellent improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the file
templates/panels/language-values.hbs, where it promotes Rust as enabling the reader "to eliminate many other classes of bugs at compile-time", to say "to eliminate many classes of bugs at compile-time" instead, without the word "other", because no classes of bugs per se previously are mentioned, leaving "other" lacking an antecedent.Per
CONTRIBUTING.md, I have filed an issue ticket first to suggest this change; the change was approved, and this patch requested, by @aturon.GitHub: Resolve #476