fix(nav): improve responsive nav behavior. #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define a class to provide flexible widths of the roughly-desirable size for small screens, and apply that to the nav. Note that it is not possible to guarantee the list *never* looks odd without CSS Grid, but here we at least minimize the number of sizes where it looks odd, and in particular improve its look on all phone views. Resolves #498.
ashleygwilliams
approved these changes
Dec 1, 2018
delete-merged-branch
bot
deleted the
improve-responsive-nav-behavior-498
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define a class to provide flexible widths of the roughly-desirable size for small screens, and apply that to the nav. Note that it is not possible to guarantee the list never looks odd without CSS Grid, but here we at least minimize the number of sizes where it looks odd, and in particular improve its look on all phone views.
You can see a video here showing the behavior – there are two very small ranges where we still get oddities, but most users should not see those.
Resolves #498.