Skip to content

Reduce homepage whitespace take 2 #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Reduce homepage whitespace take 2 #526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
960538d
Reduce vertical padding on homepage
nicoburns Nov 29, 2018
f90274f
Homepage: Reduce hero text line-height and center CTA
nicoburns Nov 29, 2018
61996d8
Homepage: padding fixes for mobile
nicoburns Nov 29, 2018
19c5c55
Homepage: Increase padding a little on non-mobile
nicoburns Nov 29, 2018
900ae79
Fix header padding on pages other than the homepage
nicoburns Dec 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/styles/app.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,22 +42,23 @@ code.code-header {
margin: 0 0 3px 0;
}

header {
padding: 2rem 0;
}

header h1, section h2 {
font-family: $header-font;
z-index: 999999;
position: relative;
}

header h1 {
line-height: 1;
font-size: 10rem;
margin-bottom: 0;
margin-top: 0;
}

header {
padding: 30px 0 60px 0;
}

header .button.button-primary.button-download {
background-color: $yellow;
border-color: $yellow;
Expand All @@ -66,7 +67,7 @@ header .button.button-primary.button-download {
padding: 20px;
height: auto;
font-size: 2em;
margin-top: 20px;
margin-top: 25px;
}

header .button.button-primary.button-download {
Expand All @@ -84,7 +85,7 @@ h2.subtitle {
}

section {
padding: 30px 0 60px 0;
padding: 30px 0;
}

ul {
Expand Down Expand Up @@ -572,7 +573,7 @@ blockquote::before {
.button.button-primary.button-download {
padding: 5px;
font-size: 1.5em;
margin-top: 20px;
margin-top: 0;
}
}
}
Expand Down
8 changes: 4 additions & 4 deletions templates/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
{{#*inline "page"}}
<header class="mb6-ns">
<header>
<div class="container flex flex-column flex-row-l justify-between-l">
<div class="mw8-l">
<h1>Rust</h1>
<h2 class="mt4 f2 f1-ns">
<h2 class="f2 f1-ns">
The programming language that empowers <em>everyone</em> to become a
systems programmer.
</h2>
</div>
<div class="mt4 mt0-l">
<div>
<a class="button button-primary button-download ph4 mt0" href="/learn/get-started">
Get started
</a>
<p class="tc f3 f2-l mt3">
<p class="tc f3 f2-l mt3 mb0">
{{rust_version}}
</p>
</div>
Expand Down
6 changes: 3 additions & 3 deletions templates/panels/language-values.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,23 +9,23 @@
<div class="flex flex-column flex-row-l pv4 pv0-l">
<section class="flex flex-column mw8 measure-wide-l pv3 pt4-ns pr4-l">
<h3 class="f2 f1-l">Performance</h3>
<p class="f3 lh-copy">
<p class="mb0 f3 lh-copy">
Rust is blazingly fast and memory-efficient: with no runtime or
garbage collector, it can power performance-critical services, run on
embedded devices, and easily integrate with other languages.
</p>
</section>
<section class="flex flex-column mw8 measure-wide-l pv3 pt4-ns ph3-l">
<h3 class="f2 f1-l">Reliability</h3>
<p class="f3 lh-copy">
<p class="mb0 f3 lh-copy">
Rust’s rich type system and ownership model guarantee memory-safety
and thread-safety &mdash; and enable you to eliminate many classes of
bugs at compile-time.
</p>
</section>
<section class="flex flex-column mw8 measure-wide-l pv3 pt4-ns pl4-l">
<h3 class="f2 f1-l">Productivity</h3>
<p class="f3 lh-copy">
<p class="mb0 f3 lh-copy">
Rust has great documentation, a friendly compiler with useful error
messages, and top-notch tooling &mdash; an integrated package manager
and build tool, smart multi-editor support with auto-completion and
Expand Down