Skip to content

Improve white space in headings #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2018
Merged

Improve white space in headings #535

merged 2 commits into from
Dec 4, 2018

Conversation

chriskrycho
Copy link
Contributor

@chriskrycho chriskrycho commented Dec 4, 2018 •
edited
Loading

small phone – home page screen shot 2018-12-03 at 8 44 00 pm
small phone – install page screen shot 2018-12-03 at 8 43 49 pm
laptop – home page screen shot 2018-12-03 at 8 44 15 pm
laptop – tools page screen shot 2018-12-03 at 8 44 29 pm

@chriskrycho chriskrycho added this to the edition-release milestone Dec 4, 2018
@chriskrycho chriskrycho changed the title Improve white space on home screen. Improve white space in headings Dec 4, 2018
@chriskrycho
fix(rustup): use <pre><code> not just <code>
87cca73 
`<code>` is an inline element, and was forcing overflow on the page on
small screens. Wrapping it in a `<pre>` element properly lets it fill
its space but then overflow into a scroll region as necessary.
@chriskrycho
fix(css): set visually-appropriate margin for all headers
d550978 
- For all top-level `<header>` items, use the desired Tachyons classes.
- Narrow the existing styles to `section header`s only.
- Combine all definitions which apply to `section header`s or their
  children in `app.scss` so they can easily be removed later.
@chriskrycho chriskrycho mentioned this pull request Dec 4, 2018
Open
ashleygwilliams
ashleygwilliams approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ashleygwilliams ashleygwilliams merged commit 2c5d904 into master Dec 4, 2018
@delete-merged-branch delete-merged-branch bot deleted the vertical-padding-446 branch December 4, 2018 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleygwilliams ashleygwilliams ashleygwilliams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
edition-release
Development

Successfully merging this pull request may close these issues.

Reduce padding on the hompage under the slogan
2 participants
@chriskrycho @ashleygwilliams