Skip to content

Use the favicon.ico used on other Rust websites and actually use it #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

ariasuni
Copy link
Contributor

@ariasuni ariasuni commented Dec 5, 2018

I found out that the differences I saw in #471 between beta.rust-lang.org and other Rust websites is simply that the other websites use a favicon.ico.

The already present favicon.ico wasn’t used and was looking bad.

Now, it’s better-looking and consistent with other Rust websites:
screenshot_20181205_013610

Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@chriskrycho chriskrycho merged commit e096077 into rust-lang:master Dec 5, 2018
@ariasuni ariasuni deleted the use-better-favicon-ico branch November 23, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants