Skip to content

Improve consistency and bump text size. #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 6, 2018
Merged

Conversation

chriskrycho
Copy link
Contributor

@chriskrycho chriskrycho commented Dec 5, 2018

This is a first step toward addressing some of the points raised in #525. I substantially increased the type size on all pages by setting a font-size in html when past the "small" screen size breakpoint specified by Tachyons. This has a couple of benefits:

  • It increases the perceived contrast between text and background throughout the site, which alleviates many of the readability issues people have, when on larger screens (if we do the same on smaller screens, we end up costing ourselves information density, which we really don't want)
  • It allows us to decrease some of the text sizes for specific headings and so on, bringing them inline with the Tachyons type scale. This increases the sense of coherence and consistency throughout the site.

On that latter note, I also shifted a few items to use Tachyons classes instead of hard-coded values, bringing line-heights and font-sizes in line with Tachyons and thereby helping them fit together a bit better (see esp. the "Rust in Production" section on the home page – there's still work to do, but it's at least much better).

Here's how it looks on big screens

larger-text

I'm by no means married to the specific base text size I chose, but I think this starts to get us in the right direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants