Skip to content

Remove fonts' lines #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2019
Merged

Conversation

JohnTitor
Copy link
Member

closes #657

It seems that #626 is already deployed but the issue isn't fixed. And I guess we can remove fonts because we use fonts.css.

@JohnTitor
Copy link
Member Author

What do you think? @carols10cents

@carols10cents
Copy link
Member

I don't know anything about this. I'm not a maintainer of the design of the site; I only make small content changes every once in a while. Please stop pinging me on this repo. Thanks!

@JohnTitor
Copy link
Member Author

Understood, I'm sorry for bothering you.

Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you've tested this, then it seems good to me. The worst regression possible here is that we lose some performance -- but that trumps the fonts being broken. Thanks for the patch; let's merge this!

@yoshuawuyts yoshuawuyts merged commit c1e7736 into rust-lang:master May 6, 2019
@JohnTitor JohnTitor deleted the remove-fonts branch May 6, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing fonts
3 participants