Add sentence about rustup update on getting started page, (issue #699) #964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
reviewed
Dec 11, 2019
Manishearth
requested changes
Jan 21, 2020
lislis
force-pushed
the
fix-699-lislis
branch
from
00747ee to
5d12d71
Compare
|
@Manishearth Can you give this one last review, and I'll merge it in? |
Manishearth
approved these changes
Jan 27, 2020
XAMPPRocky
reviewed
Jan 27, 2020
fix typo add feedback implement feedback
lislis
force-pushed
the
fix-699-lislis
branch
from
5d12d71 to
20e5032
Compare
|
Thanks for the feedback on wording! I've updated the copy and rebased on current master |
|
Thank you for your PR, and congrats on your first contribution! 🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello fine people!
I've browsed the issues and found #699.
Here you go!
It looks like this:
Let me know what you think or if you want different copy. I could also provide the German locale if desired.
Edit: updated the screenshot (again)