Skip to content

fix: handle launch errors early in client-runtime to prevent unnecessary timeout delays. #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2025

Conversation

hashemix
Copy link
Member

📌 Summary

With this fix, if client-runtime attempts to launch an MCP server and it fails, the error is now captured immediately and reported clearly.
Previously, the system would silently wait for a timeout, leaving users with no feedback about what went wrong.

✨ Changes Made

  • Launch the error reader task before calling initialize_request() to catch early failures.
  • Wait for the process to exit and clean up the pending request map to prevent unnecessary timeout delays.

@hashemix hashemix merged commit c0d05ab into main Apr 26, 2025
2 checks passed
@hashemix hashemix mentioned this pull request Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant